Enable theme translation#246
Conversation
|
Thanks for fixing what was missing with the solution! |
m-aciek
left a comment
m-aciek
left a comment
There was a problem hiding this comment.
Translation improvement suggestions, otherwise looks good to me 👍
m-aciek
left a comment
m-aciek
left a comment
There was a problem hiding this comment.
Suggestion for better portability
Co-authored-by: Maciej Olko <maciej.olko@gmail.com>
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Looks about right, but I'd appreciate a PR approval from a translator as well.
And we can always iterate and fix as needed after an initial release.
Maciek has already reviewed translation, see above. |
Yes, but not approved. |
|
In hopes of getting this in faster, I can just delete it? Fun fact, translations of the Python docs are actually not reviewed for most languages. |
|
Preview! (built with |
|
It is no longer a follow up, it is now included in this PR! Verified manually that the artefact has the compiled files. |
|
Sweet! Was setup-python really necessary, considering that python is already included in the GH runner image? |
|
It is used in all other workflows in this repository when Python is needed. |
5 participants
Adds Polish to start. Based on @rffontenelle 's pr. This does not allow for translation of the Copy button for some reason, but I think that can be left for another time.
Result:
📚 Documentation preview 📚: https://python-docs-theme-previews--246.org.readthedocs.build/
🇵🇱 Polish preview 🇵🇱